[
https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305847#comment-16305847
]
ASF GitHub Bot commented on FLINK-7797:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159009795
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
@@ -62,15 +65,23 @@ abstract class TimeBoundedStreamInnerJoin(
with Compiler[FlatJoinFunction[Row, Row, Row]]
with Logging {
- private var cRowWrapper: CRowWrappingCollector = _
+ private val leftArity = leftType.getArity
+ private val rightArity = rightType.getArity
+ private val resultArity = leftArity + rightArity
+
+ // two reusable padding results
+ private val leftNullPaddingResult = new Row(resultArity)
--- End diff --
I think we can move the code to generate padded results into a util class
that can be reused by other joins.
> Add support for windowed outer joins for streaming tables
> ---------------------------------------------------------
>
> Key: FLINK-7797
> URL: https://issues.apache.org/jira/browse/FLINK-7797
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Fabian Hueske
> Assignee: Xingcan Cui
>
> Currently, only windowed inner joins for streaming tables are supported.
> This issue is about adding support for windowed LEFT, RIGHT, and FULL OUTER
> joins.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
