[
https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306398#comment-16306398
]
ASF GitHub Bot commented on FLINK-8329:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5216
[FLINK-8329] [flip6] Move YarnClient to AbstractYarnClusterDescriptor
## What is the purpose of the change
Moves the YarnClient from the YarnClusterClient to the
AbstractYarnClusterDescriptor.
This makes the latter responsible for the lifecycle management of the
client and gives
a better separation of concerns.
This PR is based on #5215
## Brief change log
- Move the `YarnClient` from the `YarnClusterClient` to the
`AbstractYarnClusterDescriptor`
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
moveYarnClientToYarnDescriptor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5216
----
commit 69ef9787f1278f40bfeaa685379648297e1cb6f0
Author: Till Rohrmann <trohrmann@...>
Date: 2017-12-07T12:57:24Z
[FLINK-8328] [flip6] Move Yarn ApplicationStatus polling out of
YarnClusterClient
Introduce YarnApplicationStatusMonitor which does the Yarn
ApplicationStatus polling in
the FlinkYarnSessionCli. This decouples the YarnClusterClient from the
actual communication
with Yarn and, thus, gives a better separation of concerns.
commit fa3b31feba7f2dd5a2fb07cc35d56c8f1a63f75b
Author: Till Rohrmann <trohrmann@...>
Date: 2017-12-20T15:43:21Z
[FLINK-8329] [flip6] Move YarnClient to AbstractYarnClusterDescriptor
Moves the YarnClient from the YarnClusterClient to the
AbstractYarnClusterDescriptor.
This makes the latter responsible for the lifecycle management of the
client and gives
a better separation of concerns.
----
> Move YarnClient out of YarnClusterClient
> ----------------------------------------
>
> Key: FLINK-8329
> URL: https://issues.apache.org/jira/browse/FLINK-8329
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Move the {{YarnClient}} from the {{YarnClusterClient}} to the
> {{AbstractYarnClusterDescriptor}} which will be responsible for the lifecycle
> management of the {{YarnClient}}. This change is a clean up task which will
> better structure the client code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
