[
https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308186#comment-16308186
]
ASF GitHub Bot commented on FLINK-8329:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5216#discussion_r159243077
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -272,6 +275,7 @@ public void testJavaAPI() throws Exception {
LOG.info("Shutting down cluster. All tests passed");
// shutdown cluster
yarnCluster.shutdown();
+ clusterDescriptor.close();
--- End diff --
Closing in finally or try-with-resource not needed?
> Move YarnClient out of YarnClusterClient
> ----------------------------------------
>
> Key: FLINK-8329
> URL: https://issues.apache.org/jira/browse/FLINK-8329
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Move the {{YarnClient}} from the {{YarnClusterClient}} to the
> {{AbstractYarnClusterDescriptor}} which will be responsible for the lifecycle
> management of the {{YarnClient}}. This change is a clean up task which will
> better structure the client code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
