Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159128322
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final String FIRST_PART = "That is the first part";
private static final String SECOND_PART = "That is the second part";
+ @Test
+ public void testNullValueWithoutTrailingDelimiter() throws Exception {
--- End diff --
We should test the individual parsers by extending `ParserTestBase` with
tests that check for correct empty field behavior (EMPTY_COLUMN error state)
with and without a following delimiter.
IMO, the null field behavior of `RowCsvInputFormat` is sufficiently tested
by `RowCsvInputFormatTest.testEmptyFields()` such that this test does not need
to be extended.
---
