[
https://issues.apache.org/jira/browse/FLINK-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311324#comment-16311324
]
ASF GitHub Bot commented on FLINK-8338:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5224#discussion_r159644962
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendPackageProgramTest.java
---
@@ -60,7 +62,10 @@ public static void init() {
@Test
public void testNonExistingJarFile() {
try {
- CliFrontend frontend = new
CliFrontend(CliFrontendTestUtils.getConfigDir());
+ CliFrontend frontend = new CliFrontend(
--- End diff --
Just an observation: The diff is only big because the instance under test
is not an instance variable, and set up in a `@Before` annotated method.
> Make CustomCommandLines non static in CliFrontend
> -------------------------------------------------
>
> Key: FLINK-8338
> URL: https://issues.apache.org/jira/browse/FLINK-8338
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> For better testability and maintainability we should make the
> {{CustomCommandLine}} registration non-static in {{CliFrontend}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
