Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159707553
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyCustomCommandLine.java
---
@@ -62,12 +63,21 @@ public void addGeneralOptions(Options baseOptions) {
}
@Override
- public T retrieveCluster(CommandLine commandLine, Configuration config,
String configurationDirectory) throws UnsupportedOperationException {
- return clusterClient;
+ public ClusterDescriptor<T> createClusterDescriptor(
+ Configuration configuration,
+ String configurationDirectory,
+ CommandLine commandLine) {
+ return new DummyClusterDescriptor<>(clusterClient);
}
@Override
- public T createCluster(String applicationName, CommandLine commandLine,
Configuration config, String configurationDirectory, List<URL> userJarFiles)
throws Exception {
- return clusterClient;
+ @Nullable
+ public String getClusterId(Configuration configuration, CommandLine
commandLine) {
+ return "dummy";
+ }
+
+ @Override
+ public ClusterSpecification getClusterSpecification(Configuration
configuration, CommandLine commandLine) {
+ return new
ClusterSpecification.ClusterSpecificationBuilder().createClusterSpecification();
--- End diff --
See comment on `DefaultCLI.java`
---
