Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160108309
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.yarn;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.util.Preconditions;
+import org.apache.flink.util.TestLogger;
+
+import org.apache.hadoop.yarn.api.records.ApplicationAttemptId;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ApplicationReport;
+import org.apache.hadoop.yarn.api.records.FinalApplicationStatus;
+import org.apache.hadoop.yarn.api.records.YarnApplicationState;
+import org.apache.hadoop.yarn.client.api.YarnClient;
+import org.apache.hadoop.yarn.client.api.impl.YarnClientImpl;
+import org.apache.hadoop.yarn.exceptions.YarnException;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.Map;
+
+import static org.junit.Assert.fail;
+
+/**
+ * Tests for the {@link AbstractYarnClusterDescriptor}.
+ */
+public class AbstractYarnClusterTest extends TestLogger {
+
+ @Rule
+ public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ /**
+ * Tests that the cluster retrieval of a finished YARN application
fails.
+ */
+ @Test(expected = RuntimeException.class)
+ public void testClusterClientRetrievalOfFinishedYarnApplication()
throws IOException {
+ final ApplicationId applicationId =
ApplicationId.newInstance(System.currentTimeMillis(), 42);
+ final String clusterId = applicationId.toString();
+ final ApplicationReport applicationReport =
ApplicationReport.newInstance(
+ applicationId,
+ ApplicationAttemptId.newInstance(applicationId, 0),
+ "user",
+ "queue",
+ "name",
+ "localhost",
+ 42,
+ null,
+ YarnApplicationState.FINISHED,
+ null,
+ null,
+ 1L,
+ 2L,
+ FinalApplicationStatus.SUCCEEDED,
+ null,
+ null,
+ 1.0f,
+ null,
+ null);
+
+ final YarnClient yarnClient = new
TestingYarnClient(Collections.singletonMap(applicationId, applicationReport));
+
+ final TestingAbstractYarnClusterDescriptor clusterDescriptor =
new TestingAbstractYarnClusterDescriptor(
+ new Configuration(),
+ temporaryFolder.newFolder().getAbsolutePath(),
+ yarnClient);
+
+ clusterDescriptor.retrieve(clusterId);
+
+ fail("We should not be able to retrieve ClusterClient for a
finished Yarn application.");
+ }
+
+ @Test
+ public void testClusterClientRetrievalFromInvalidYarnId() {
--- End diff --
This test is empty.
---
