[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...

[sunjincheng121]

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5202#discussion_r160047969
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
 ---
    @@ -58,4 +58,22 @@ object ScalarSqlFunctions {
           OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC)),
         SqlFunctionCategory.NUMERIC)
     
    +  val SHIFT_LEFT = new SqlFunction(
    +    "SHIFT_LEFT",
    +    SqlKind.OTHER_FUNCTION,
    +    ReturnTypes.ARG0,
    +    null,
    +    OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.INTEGER),
    --- End diff --
    
    I check the type defined in calcite, `SqlTypeFamily.INTEGER` is 
     `SqlTypeName.INT_TYPES` contains `(TINYINT, SMALLINT, INTEGER, BIGINT)`, 
So we should change `SqlTypeFamily.NUMERIC` to `SqlTypeFamily.INTEGER` . 


---