Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5232#discussion_r160209875
  
    --- Diff: 
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
    @@ -83,7 +83,7 @@ public void 
testClusterClientRetrievalOfFinishedYarnApplication() throws IOExcep
                        temporaryFolder.newFolder().getAbsolutePath(),
                        yarnClient);
     
    -           clusterDescriptor.retrieve(clusterId);
    +           clusterDescriptor.retrieve(applicationId);
     
                fail("We should not be able to retrieve ClusterClient for a 
finished Yarn application.");
    --- End diff --
    
    As written on a previous PR, `fail` should not be used in this case.


---

Reply via email to