Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5200#discussion_r160599433
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
@@ -51,7 +50,7 @@
* the Flink data streams.
* @param <KPH> The type of topic/partition identifier used by Kafka in
the specific version.
*/
-public abstract class AbstractFetcher<T, KPH> {
+public abstract class AbstractFetcher<T, KPH> implements
KafkaOffsetCommitter {
--- End diff --
The result could also very well be that we should use this opportunity to
refactor the vague dependencies between fetcher / consumer thread / consumer
base, and include in this PR. I would not be against that.
---
