Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5200#discussion_r160692827
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
@@ -51,7 +50,7 @@
* the Flink data streams.
* @param <KPH> The type of topic/partition identifier used by Kafka in
the specific version.
*/
-public abstract class AbstractFetcher<T, KPH> {
+public abstract class AbstractFetcher<T, KPH> implements
KafkaOffsetCommitter {
--- End diff --
Probably you are right, however I haven't thought this through, but if you
had and you feel that's a good opportunity to make some larger refactor I'm
fine with that :)
Anyway, as we discussed offline, such refactor could be made in separate PR
and here you could just implement
`AbstractFetcher#doCommitInternalOffsetsToKafka` for the testing purposes.
I don't mind if you choose one over the other approach :)
---
