[GitHub] flink pull request #4127: [FLINK-6892][table]Add L/RPAD supported in SQL

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4127#discussion_r160629826
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
 ---
    @@ -352,6 +352,24 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
           "Flink~~~~xx")
       }
     
    +  @Test
    +  def testLpad(): Unit = {
    +    testSqlApi("LPAD('hi',4,'??')", "??hi")
    --- End diff --
    
    Add a test with unicode characters.


---