[
https://issues.apache.org/jira/browse/FLINK-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319978#comment-16319978
]
ASF GitHub Bot commented on FLINK-6892:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4127#discussion_r160630263
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/validation/ScalarFunctionsValidationTest.scala
---
@@ -78,10 +78,21 @@ class ScalarFunctionsValidationTest extends
ScalarTypesTestBase {
}
@Test(expected = classOf[ValidationException])
- def testTimestampAddWithWrongQuantity(): Unit ={
+ def testTimestampAddWithWrongQuantity(): Unit = {
testSqlApi("TIMESTAMPADD(YEAR, 1.0, timestamp '2016-02-24 12:42:25')",
"2016-06-16")
}
+ @Test(expected = classOf[ValidationException])
+ def testLpadWithNull(): Unit = {
+ // Must fail. Parameter of base string must not be null.
+ testSqlApi("LPAD(null,1,'??')", "")
--- End diff --
I think we don't need to fail here. Returning null should be the SQL
standard here.
> Add L/RPAD supported in SQL
> ---------------------------
>
> Key: FLINK-6892
> URL: https://issues.apache.org/jira/browse/FLINK-6892
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> L/RPAD(str,len,padstr) Returns the string str, left/right-padded with the
> string padstr to a length of len characters. If str is longer than len, the
> return value is shortened to len characters.
> * Syntax:
> LPAD(str,len,padstr)
> * Arguments
> **str: -
> **len: -
> **padstr: -
> * Return Types
> String
> * Example:
> LPAD('hi',4,'??') -> '??hi'
> LPAD('hi',1,'??') -> 'h'
> RPAD('hi',4,'??') -> 'hi??'
> RPAD('hi',1,'??') -> 'h'
> * See more:
> ** [MySQL|
> https://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_lpad]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
