[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

[NicoK]

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r161570121
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionTest.java
 ---
    @@ -119,6 +119,7 @@ public void testBasicPipelinedProduceConsumeLogic() 
throws Exception {
                verify(listener, times(1)).notifyBuffersAvailable(eq(1L));
     
                // ...and one available result
    +           assertFalse(view.nextBufferIsEvent());
    --- End diff --
    
    also test `read.buffer().isBuffer()` then?


---