GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5301
[FLINK-8267] [Kinesis Connector] update Kinesis Producer example for
setting Region key
## What is the purpose of the change
Update doc to guide users to use KPL's native keys to set regions.
This originates from a bug that we forgot to set region keys explicitly for
kinesis connector, which has been fixed. According to the previous discussion
between @tzulitai and I, we want to remove AWSConfigConstants in 2.0 because it
basically copies/translates config keys of KPL/KCL, which doesn't add much
value.
Guide users to use KPL's native keys to set regions can be the first step
that facilitates the migration.
## Brief change log
- updated doc
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
## Documentation
- Does this pull request introduce a new feature? (no)
cc @tzulitai
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-8267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5301
----
commit b4034f67e727fef68740221e3b31cd131c905df1
Author: Bowen Li <bowenli86@...>
Date: 2018-01-02T19:21:28Z
update local branch
commit 11e9c255cd51304c5281d55226fbb6fe8360d8a2
Author: Bowen Li <bowenli86@...>
Date: 2018-01-04T01:35:11Z
remove sh
commit e322a5416b0f4f89c366b98bb3571fbf6b7d460a
Author: Bowen Li <bowenli86@...>
Date: 2017-12-17T06:18:55Z
update doc
commit 1b447633df4a8bfe7c4c19e7ae91aab6157756d7
Author: Bowen Li <bowenli86@...>
Date: 2018-01-15T23:48:38Z
format code snippet
commit 4ede4b5a89d4bfcda8dcc845ab1da42177d22358
Author: Bowen Li <bowenli86@...>
Date: 2018-01-15T23:49:37Z
remove ';' from scala code
----
---
