[
https://issues.apache.org/jira/browse/FLINK-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331254#comment-16331254
]
ASF GitHub Bot commented on FLINK-8431:
---------------------------------------
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/5307#discussion_r162468156
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/Offer.java ---
@@ -156,6 +164,16 @@ public long getOfferedTime() {
return attributeMap;
}
+ @Override
+ public Double getScalarValue(String name) {
+ return aggregatedScalarResourceMap.getOrDefault(name, 0.0);
+ }
+
+ @Override
+ public Map<String, Double> getScalarValues() {
+ return aggregatedScalarResourceMap;
--- End diff --
I notice that we return all scalar resource types (`cpus`, `gpus`, ...)
here, but in `LaunchableMesosWorker::getScalarRequests` we return only the
generic resource types (`gpus`). Would you please double-check that this is
expected by Fenzo? I wouldn't want Fenzo to double-count the `cpus` or
something.
> Allow to specify # GPUs for TaskManager in Mesos
> ------------------------------------------------
>
> Key: FLINK-8431
> URL: https://issues.apache.org/jira/browse/FLINK-8431
> Project: Flink
> Issue Type: Improvement
> Components: Cluster Management, Mesos
> Reporter: Dongwon Kim
> Assignee: Dongwon Kim
> Priority: Minor
>
> Mesos provides first-class support for Nvidia GPUs [1], but Flink does not
> exploit it when scheduling TaskManagers. If Mesos agents are configured to
> isolate GPUs as shown in [2], TaskManagers that do not specify to use GPUs
> cannot see GPUs at all.
> We, therefore, need to introduce a new configuration property named
> "mesos.resourcemanager.tasks.gpus" to allow users to specify # of GPUs for
> each TaskManager process in Mesos.
> [1] http://mesos.apache.org/documentation/latest/gpu-support/
> [2] http://mesos.apache.org/documentation/latest/gpu-support/#agent-flags
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
