[ https://issues.apache.org/jira/browse/FLINK-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331637#comment-16331637 ]
ASF GitHub Bot commented on FLINK-8431: --------------------------------------- Github user eastcirclek commented on a diff in the pull request: https://github.com/apache/flink/pull/5307#discussion_r162524332 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -238,6 +254,16 @@ public static MesosTaskManagerParameters create(Configuration flinkConfig) { cpus = Math.max(containeredParameters.numSlots(), 1.0); } + double gpus = flinkConfig.getDouble(MESOS_RM_TASKS_GPUS, 0.0); + if (gpus < 0) { + throw new IllegalConfigurationException(MESOS_RM_TASKS_GPUS.key() + + " cannot be negative"); + } + if (gpus % 1 != 0) { --- End diff -- I tested that `(1.000000000000001 % 1) != 0` is true while `(1.0000000000000001 % 1) != 0` is false. > Allow to specify # GPUs for TaskManager in Mesos > ------------------------------------------------ > > Key: FLINK-8431 > URL: https://issues.apache.org/jira/browse/FLINK-8431 > Project: Flink > Issue Type: Improvement > Components: Cluster Management, Mesos > Reporter: Dongwon Kim > Assignee: Dongwon Kim > Priority: Minor > > Mesos provides first-class support for Nvidia GPUs [1], but Flink does not > exploit it when scheduling TaskManagers. If Mesos agents are configured to > isolate GPUs as shown in [2], TaskManagers that do not specify to use GPUs > cannot see GPUs at all. > We, therefore, need to introduce a new configuration property named > "mesos.resourcemanager.tasks.gpus" to allow users to specify # of GPUs for > each TaskManager process in Mesos. > [1] http://mesos.apache.org/documentation/latest/gpu-support/ > [2] http://mesos.apache.org/documentation/latest/gpu-support/#agent-flags -- This message was sent by Atlassian JIRA (v7.6.3#76005)