[
https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332420#comment-16332420
]
ASF GitHub Bot commented on FLINK-8325:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r162643699
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -829,7 +833,8 @@ object AggregateUtil {
outputType: RelDataType,
groupings: Array[Int]): (Option[DataSetPreAggFunction],
Option[TypeInformation[Row]],
- RichGroupReduceFunction[Row, Row]) = {
+ RichGroupReduceFunction[Row, Row],
+ Option[MapPartitionFunction[Row, Row]]) = {
--- End diff --
Please remove this parameter and extend `DataSetFinalAggFunction` to also
implement `RichMapPartitionFunction` such that it can be used as both (similar
to `DataSetPreAggFunction`).
> Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)
> ------------------------------------------------------------------
>
> Key: FLINK-8325
> URL: https://issues.apache.org/jira/browse/FLINK-8325
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.5.0
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
>
> COUNT(1) with Group Window, always output 0.
> e.g.
> DATA:
> {code}
> val data = List(
> (1L, 1, "Hi"),
> (2L, 2, "Hello"),
> (4L, 2, "Hello"),
> (8L, 3, "Hello world"),
> (16L, 3, "Hello world"))
> {code}
> SQL:
> {code}
> SELECT b, COUNT(1) FROM MyTable GROUP BY Hop(proctime, interval '0.001'
> SECOND, interval '0.002' SECOND),b
> {code}
> OUTPUT:
> {code}
> 1,0,1,
> 1,0,1,
> 2,0,1,
> 2,0,1,
> 2,0,2,
> 3,0,1,
> 3,0,1
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
