[
https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333405#comment-16333405
]
ASF GitHub Bot commented on FLINK-8428:
---------------------------------------
GitHub user hequn8128 opened a pull request:
https://github.com/apache/flink/pull/5327
[FLINK-8428] [table] Implement stream-stream non-window left outer join
## What is the purpose of the change
Implement stream-stream non-window left outer join for sql/table-api. A
simple design doc can be found
[here](https://docs.google.com/document/d/1u7bJHeEBP_hFhi8Jm4oT3FqQDOm2pJDqCtq1U1WMHDo/edit?usp=sharing)
## Brief change log
- Add left join
- with non-equal predicates
- without non-equal predicates
- Adapt retraction rules to left join. Outer join will generate
retractions
- Adapt `UpsertTableSink`. Table mode of dynamic table produced by left
join is Update Mode, even if the table does not include a key definition
- Add inner join test cases which consistent with test cases in batch.
- Add left join test cases which consistent with test cases in batch.
## Verifying this change
This change added tests and can be verified as follows:
- Added integration tests for left join with or without non-equal
predicates.
- Added HarnessTests left join with or without non-equal predicates.
- Add tests for AccMode generate by left join.
- Add tests for UpsertSink followed left join.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (already docs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hequn8128/flink leftjoin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5327
----
commit 2766de56d47e1a82f6605eb1dd80d8ea5e697a29
Author: hequn8128 <chenghequn@...>
Date: 2018-01-21T04:54:08Z
[FLINK-8428] [table] Implement stream-stream non-window left outer join
----
> Implement stream-stream non-window left outer join
> --------------------------------------------------
>
> Key: FLINK-8428
> URL: https://issues.apache.org/jira/browse/FLINK-8428
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
