Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5240#discussion_r163071426
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/typeutils/TypeStringUtils.scala
 ---
    @@ -0,0 +1,213 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.typeutils
    +
    +import java.io.Serializable
    +
    +import org.apache.commons.codec.binary.Base64
    +import org.apache.commons.lang3.StringEscapeUtils
    +import org.apache.flink.api.common.typeinfo.{BasicArrayTypeInfo, 
PrimitiveArrayTypeInfo, TypeInformation}
    +import org.apache.flink.api.common.typeutils.CompositeType
    +import org.apache.flink.api.java.typeutils._
    +import org.apache.flink.table.api.{TableException, Types, 
ValidationException}
    +import 
org.apache.flink.table.descriptors.NormalizedProperties.normalizeTypeInfo
    +import org.apache.flink.util.InstantiationUtil
    +
    +import _root_.scala.language.implicitConversions
    +import _root_.scala.util.parsing.combinator.{JavaTokenParsers, 
PackratParsers}
    +
    +/**
    +  * Utilities to convert 
[[org.apache.flink.api.common.typeinfo.TypeInformation]] into a
    +  * string representation and back.
    +  */
    +object TypeStringUtils extends JavaTokenParsers with PackratParsers {
    --- End diff --
    
    We need unit tests for the parser.


---

Reply via email to