Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5240#discussion_r163065450
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactory.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.sources
+
+import java.util
+
+/**
+ * A factory to create a [[TableSource]]. This factory is used with
Java's Service Provider
+ * Interfaces (SPI) for discovering. A factory is called with a set of
normalized properties that
+ * describe the desired table source. The factory allows for matching to
the given set of
+ * properties and creating a configured [[TableSource]] accordingly.
+ *
+ * Classes that implement this interface need to be added to the
+ * "META_INF/services/org.apache.flink.table.sources.TableSourceFactory'
file of a JAR file in
--- End diff --
do all need to be added to the same file? Or can we have separate files for
different modules. For instance, a `Kafka011JsonTableFactory` would be in the
Kafka connectors module. Would a user have to change the service file if the
Kafka factory should be used or can we built it in a way that it is sufficient
include the Kafka connectors JAR?
---
