[
https://issues.apache.org/jira/browse/FLINK-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337527#comment-16337527
]
ASF GitHub Bot commented on FLINK-8502:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5352
[FLINK-8502] [flip6] Remove LibraryCacheManager from JobMaster
## What is the purpose of the change
This commit removes the LibraryCacheManager from the JobMaster since it is
no longer needed. The JobMaster is started with the correct user code class
loader and, thus, does not need the LibraryCacheManager.
This commit also corrects that the BlobServer is not closed by the
JobManagerServices#shutdown method.
This PR is based on #5350.
## Brief change log
- Remove `LibraryCacheManager` from `JobMaster`
- Remove closing of `BlobServer` from `JobManagerServices`
## Verifying this change
- Covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
removeUnnecessaryJobMasterComponents
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5352.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5352
----
commit b9db2ab22c346ec64363b446ed23692af1365239
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-23T18:12:27Z
[FLINK-8501] [flip6] Use single BlobCacheService per TaskExecutor
Instead of creating for each new JobManagerConnection a dedicated
BlobCacheService
the TaskExecutor uses a single BlobCacheService which it shares between the
different JobManagerConnections. The initial BlobServer address is passed
by the
ResourceManager when the TaskExecutor registers at it. In order to avoid
the re-
creation of BlobCacheServices, this commit changes the behaviour such that
one can
update the BlobServer address.
commit 32f2e63783f04707dad91923c0a2c84bb118feff
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-24T12:35:50Z
[FLINK-8502] [flip6] Remove LibraryCacheManager from JobMaster
This commit removes the LibraryCacheManager from the JobMaster since it is
no longer needed. The JobMaster is started with the correct user code class
loader and, thus, does not need the LibraryCacheManager.
This commit also corrects that the BlobServer is not closed by the
JobManagerServices#shutdown method.
----
> Remove LibraryCacheManager from JobMaster
> -----------------------------------------
>
> Key: FLINK-8502
> URL: https://issues.apache.org/jira/browse/FLINK-8502
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{JobMaster}} does not need access to the {{LibraryCacheManager}} because
> it is already started with the user code class loader. We should, therefore,
> remove the unused components.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
