Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5240#discussion_r163830189
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
 ---
    @@ -107,6 +111,16 @@ abstract class BatchTableEnvironment(
         }
       }
     
    +  /**
    +    * Creates a table from a descriptor that describes the resulting table 
schema, the source
    +    * connector, source encoding, and other properties.
    +    *
    +    * @param schema schema descriptor describing the table to create
    +    */
    +  def createTable(schema: Schema): BatchTableSourceDescriptor = {
    --- End diff --
    
    I will improve the definition but in general I think it is nice to have 
more fluent API without too much nesting. It is also inconvenient to call a 
method on table environment and pass it to its parameters.


---

Reply via email to