Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5240#discussion_r164131675
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/CSV.scala
---
@@ -139,26 +139,26 @@ class CSV extends EncodingDescriptor("csv") {
}
/**
- * Internal method for encoding properties conversion.
+ * Internal method for format properties conversion.
*/
- override protected def addEncodingProperties(properties:
NormalizedProperties): Unit = {
- fieldDelim.foreach(properties.putString("field-delimiter", _))
- lineDelim.foreach(properties.putString("line-delimiter", _))
- properties.putTableSchema("fields", encodingSchema.toIndexedSeq)
- quoteCharacter.foreach(properties.putCharacter("quote-character", _))
- commentPrefix.foreach(properties.putString("comment-prefix", _))
- isIgnoreFirstLine.foreach(properties.putBoolean("ignore-first-line",
_))
- lenient.foreach(properties.putBoolean("ignore-parse-errors", _))
+ override protected def addFormatProperties(properties:
NormalizedProperties): Unit = {
+
fieldDelim.foreach(properties.putString(DescriptorUtils.FIELD_DELIMITER, _))
--- End diff --
I would not define the constants globally. Some constants should be global,
but constants for specific connectors or formats, should go to the respective
descriptor.
IMO, it would be better to have these keys in `CSV` or the class that
validates the properties of a certain type.
---
