Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5269#discussion_r165019903
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@ -484,7 +484,10 @@ protected Properties getConsumerConfiguration() {
*/
protected final void emitRecordAndUpdateState(T record, long
recordTimestamp, int shardStateIndex, SequenceNumber lastSequenceNumber) {
synchronized (checkpointLock) {
- sourceContext.collectWithTimestamp(record,
recordTimestamp);
+ if (record != null) {
+ sourceContext.collectWithTimestamp(record,
recordTimestamp);
--- End diff --
Are we silently skipping the record or do we log _somewhere_ that a record
was invalid?
---
