Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5269#discussion_r165039352
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
 ---
    @@ -484,7 +484,10 @@ protected Properties getConsumerConfiguration() {
         */
        protected final void emitRecordAndUpdateState(T record, long 
recordTimestamp, int shardStateIndex, SequenceNumber lastSequenceNumber) {
                synchronized (checkpointLock) {
    -                   sourceContext.collectWithTimestamp(record, 
recordTimestamp);
    +                   if (record != null) {
    +                           sourceContext.collectWithTimestamp(record, 
recordTimestamp);
    --- End diff --
    
    We currently do not have a log for that.
    I'll add a warning log if the record is null.


---

Reply via email to