Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5393#discussion_r165084048
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@ -584,17 +594,34 @@ private static ShardMetricsReporter
registerShardMetrics(MetricGroup metricGroup
// Miscellaneous utility functions
//
------------------------------------------------------------------------
+ /**
+ * Function to map a Kinesis shard to a Flink subtask index.
+ */
+ public interface ShardToSubtaskIndexFn {
+ /**
+ * Function to map a Kinesis shard to a Flink subtask index.
--- End diff --
This needs a much more stronger Javadoc explaining the contract of
deterministic assignments.
See `KafkaTopicPartitionAssigner` for an example.
---
