Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5393#discussion_r165081311
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
 ---
    @@ -584,17 +594,34 @@ private static ShardMetricsReporter 
registerShardMetrics(MetricGroup metricGroup
        //  Miscellaneous utility functions
        // 
------------------------------------------------------------------------
     
    +   /**
    +    * Function to map a Kinesis shard to a Flink subtask index.
    +    */
    +   public interface ShardToSubtaskIndexFn {
    --- End diff --
    
    This also needs to be `Serializable`, since it'll be shipped along with the 
`JobGraph` to the JM.


---

Reply via email to