Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5353#discussion_r165962518
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCache.java
 ---
    @@ -222,7 +221,13 @@ public File getStorageLocation(@Nullable JobID jobId, 
BlobKey key) throws IOExce
        }
     
        private BlobClient createClient() throws IOException {
    -           return new BlobClient(serverAddress, blobClientConfig);
    +           final InetSocketAddress currentServerAddress = serverAddress;
    +
    +           if (currentServerAddress != null) {
    +                   return new BlobClient(serverAddress, blobClientConfig);
    --- End diff --
    
    I think you should use `currentServerAddress`, or the creation can fail 
with an NPE. 


---

Reply via email to