Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5400#discussion_r167162743
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BarrierBufferTestBase.java
 ---
    @@ -0,0 +1,194 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.runtime.io;
    +
    +import org.apache.flink.core.memory.MemorySegment;
    +import org.apache.flink.core.memory.MemorySegmentFactory;
    +import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
    +import org.apache.flink.runtime.checkpoint.CheckpointMetrics;
    +import org.apache.flink.runtime.checkpoint.CheckpointOptions;
    +import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
    +import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
    +import org.apache.flink.runtime.io.network.api.EndOfPartitionEvent;
    +import org.apache.flink.runtime.io.network.buffer.Buffer;
    +import org.apache.flink.runtime.io.network.buffer.FreeingBufferRecycler;
    +import org.apache.flink.runtime.io.network.buffer.NetworkBuffer;
    +import 
org.apache.flink.runtime.io.network.partition.consumer.BufferOrEvent;
    +import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
    +import org.apache.flink.runtime.operators.testutils.DummyEnvironment;
    +
    +import org.hamcrest.BaseMatcher;
    +import org.hamcrest.Description;
    +
    +import java.util.Random;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNotNull;
    +import static org.junit.Assert.assertTrue;
    +
    +/**
    + * Utility class containing common methods for testing
    + * {@link BufferSpillerTest} and {@link CreditBasedBufferBlockerTest}.
    + */
    +public class BarrierBufferTestBase {
    --- End diff --
    
    This is not exactly what I had in mind by deduplication of 
`BarrierBufferTest` and `CreditBasedBarrierBufferTest`.  Both of those tests 
are still pretty much copy of one another and those static methods are only a 
fraction of duplication.
    
    Look for example at the `testSingleChannelNoBarriers()` they are 99% 
identical. All of it's code could be moved to `BarrierBufferTestBase`. 
`BarrierBufferTestBase` would only need to define abstract method 
`CheckpointBarrierHandler createBarrierHandler()` which would be define 
differently in `BarrierBufferTest` and `CreditBasedBarrierBufferTest`. One 
minor thing is that `BarrierBufferTest` would need `checkNoTempFilesRemain()` 
added as an `@After` test hook. Same applies to all of the other tests.


---

Reply via email to