[
https://issues.apache.org/jira/browse/FLINK-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360482#comment-16360482
]
ASF GitHub Bot commented on FLINK-8212:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5458
[FLINK-8212] [network] Pull EnvironmentInformation out of TaskManager…
## What is the purpose of the change
Pull EnvironmentInformation out of TaskManagerServices
## Brief change log
Add inner class ```TaskExecutorEnvironmentInformation``` that can give
access to the execution environment of the JVM.
## Verifying this change
Run ```NetworkBufferCalculationTest``` is OKay.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: ( no)
- The runtime per-record code paths (performance sensitive): ( don't
know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-8212
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5458
----
commit a4792758d3620359f9f42c3bcffbe7578bba4048
Author: zhangminglei <zml13856086071@...>
Date: 2018-02-12T09:21:42Z
[FLINK-8212] [network] Pull EnvironmentInformation out of
TaskManagerServices
----
> Pull EnvironmentInformation out of TaskManagerServices
> ------------------------------------------------------
>
> Key: FLINK-8212
> URL: https://issues.apache.org/jira/browse/FLINK-8212
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime, Network
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Priority: Major
> Fix For: 1.5.0
>
>
> We should pull the {{EnvironmentInformation}} out of the
> {{TaskManagerServices}} where it is used to get access to the memory settings
> of the executing JVM. This unnecessarily couples the former with the latter
> and makes testing extremely hard (one has to use {{PowerMockRunner}} and mock
> the static {{EnvironmentInformation}}).
> When addressing this issue, then we should also refactor
> {{NetworkBufferCalculationTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
