Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5423#discussion_r167621132
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java
 ---
    @@ -60,12 +60,20 @@
        void tagAsEvent();
     
        /**
    -    * Returns the underlying memory segment.
    +    * Returns the underlying memory segment. This method is dangerous 
since it ignores read only protections and omits
    +    * slices. Use it only along the {@link #getMemorySegmentOffset()}.
         *
         * @return the memory segment backing this buffer
         */
    +   @Deprecated
    --- End diff --
    
    You should name the proper replacement for this deprecated method in the 
comment, or say that it will be eventually removed without replacement.


---

Reply via email to