Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5423#discussion_r167594824
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
 ---
    @@ -131,9 +114,9 @@ public void release() {
                        }
     
                        // Release all available buffers
    -                   Buffer buffer;
    -                   while ((buffer = buffers.poll()) != null) {
    -                           buffer.recycleBuffer();
    +                   BufferConsumer bufferConsumer;
    +                   while ((bufferConsumer = buffers.poll()) != null) {
    --- End diff --
    
    I suggest to just make a normal for-each iteration to close all, followed 
by a clear.


---

Reply via email to