[ https://issues.apache.org/jira/browse/FLINK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362524#comment-16362524 ]
ASF GitHub Bot commented on FLINK-8581: --------------------------------------- Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5423#discussion_r167594824 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java --- @@ -131,9 +114,9 @@ public void release() { } // Release all available buffers - Buffer buffer; - while ((buffer = buffers.poll()) != null) { - buffer.recycleBuffer(); + BufferConsumer bufferConsumer; + while ((bufferConsumer = buffers.poll()) != null) { --- End diff -- I suggest to just make a normal for-each iteration to close all, followed by a clear. > Improve performance for low latency network > ------------------------------------------- > > Key: FLINK-8581 > URL: https://issues.apache.org/jira/browse/FLINK-8581 > Project: Flink > Issue Type: Improvement > Components: Network > Affects Versions: 1.5.0 > Reporter: Piotr Nowojski > Assignee: Piotr Nowojski > Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)