[
https://issues.apache.org/jira/browse/FLINK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362533#comment-16362533
]
ASF GitHub Bot commented on FLINK-8581:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5423#discussion_r167860402
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
---
@@ -209,22 +171,38 @@ public void setMetricGroup(TaskIOMetricGroup metrics)
{
}
/**
- * Writes the buffer to the {@link ResultPartitionWriter} and removes
the
- * buffer from the serializer state.
+ * Marks the current {@link BufferBuilder} as finished and clears the
state for next one.
*
- * <p><b>Needs to be synchronized on the serializer!</b>
+ * @return true if some data were written
*/
- private void writeAndClearBuffer(
- Buffer buffer,
+ private boolean tryFinishCurrentBufferBuilder(
int targetChannel,
RecordSerializer<T> serializer) throws IOException {
--- End diff --
This code no longer throws `IOException`.
> Improve performance for low latency network
> -------------------------------------------
>
> Key: FLINK-8581
> URL: https://issues.apache.org/jira/browse/FLINK-8581
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
