[
https://issues.apache.org/jira/browse/FLINK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362531#comment-16362531
]
ASF GitHub Bot commented on FLINK-8581:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5423#discussion_r167527566
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/RecordSerializer.java
---
@@ -87,41 +86,12 @@ public boolean isFullBuffer() {
SerializationResult setNextBufferBuilder(BufferBuilder bufferBuilder)
throws IOException;
--- End diff --
One remark from reading the code, I found it a bit surprising that a method
that looks like a setter will case the write to continue. Maybe this is better
called something like `continueWritingWithNextBufferBuilder` or split the
setter from a `continueWrite` method?
> Improve performance for low latency network
> -------------------------------------------
>
> Key: FLINK-8581
> URL: https://issues.apache.org/jira/browse/FLINK-8581
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
