Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5481#discussion_r168121129
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/KeyedProcessOperatorTest.java
 ---
    @@ -397,17 +396,16 @@ public void processElement(Integer value, Context 
ctx, Collector<String> out) th
                }
     
                @Override
    -           public void onTimer(
    -                           long timestamp,
    -                           OnTimerContext ctx,
    -                           Collector<String> out) throws Exception {
    +           public void onTimer(long timestamp, OnTimerContext ctx, 
Collector<String> out) throws Exception {
                }
        }
     
        private static class TriggeringFlatMapFunction extends 
ProcessFunction<Integer, Integer> {
     
                private static final long serialVersionUID = 1L;
     
    +           static final int TEST_VALUE = 17;
    +
                private final TimeDomain timeDomain;
     
                public TriggeringFlatMapFunction(TimeDomain timeDomain) {
    --- End diff --
    
    rename `timeDomain` -> `expectedTimeDomain` and add `expectedKey` and add 
assertion for the expected key to `onTimer()` method triggered both in 
`KeyedProcessOperatorTest#testEventTimeTimers` and 
`KeyedProcessOperatorTest#testProcessingTimeTimers`


---

Reply via email to