[GitHub] flink pull request #5481: [FLINK-8560] Access to the current key in ProcessF...

[bowenli86]

Github user bowenli86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5481#discussion_r168265503
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
 ---
    @@ -162,7 +162,7 @@ class GroupAggProcessFunction(
     
       override def onTimer(
           timestamp: Long,
    -      ctx: ProcessFunction[CRow, CRow]#OnTimerContext,
    +      ctx: ProcessFunction[CRow, CRow]#OnTimerContext[_],
    --- End diff --
    
    yes, I think I'll create a `KeyedProcessFunction` as Aljoscha suggested, 
and we probably don't need these scala changes any more.


---