[
https://issues.apache.org/jira/browse/FLINK-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365474#comment-16365474
]
ASF GitHub Bot commented on FLINK-8614:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5437#discussion_r168461190
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
---
@@ -100,6 +101,18 @@ public MiniDispatcher(
return acknowledgeCompletableFuture;
}
+ @Override
+ public CompletableFuture<JobResult> requestJobResult(JobID jobId, Time
timeout) {
+ final CompletableFuture<JobResult> jobResultFuture =
super.requestJobResult(jobId, timeout);
+
+ if (executionMode == ClusterEntrypoint.ExecutionMode.NORMAL) {
+ // terminate the MiniDispatcher once we served the
first JobResult successfully
+ jobResultFuture.thenRun(this::shutDown);
--- End diff --
Don't know if it is a problem but if the future is completed exceptionally,
`shutDown` will not be invoked.
public static void main(String[] args) {
FutureUtils.completedExceptionally(new
RuntimeException()).thenRun(() -> System.out.println("not printed"));
}
> Enable Flip-6 per default
> -------------------------
>
> Key: FLINK-8614
> URL: https://issues.apache.org/jira/browse/FLINK-8614
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> After adding the FLINK-8471, the next step is to enable Flip-6 per default by
> setting the configuration switch to {{flip6}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
