[ 
https://issues.apache.org/jira/browse/FLINK-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365473#comment-16365473
 ] 

ASF GitHub Bot commented on FLINK-8614:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5437#discussion_r168459950
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java 
---
    @@ -402,6 +403,24 @@ public void start() throws Exception {
                }
        }
     
    +   @Override
    +   public CompletableFuture<JobResult> requestJobResult(JobID jobId, Time 
timeout) {
    +           final JobManagerRunner jobManagerRunner = 
jobManagerRunners.get(jobId);
    +
    +           if (jobManagerRunner == null) {
    +                   final ArchivedExecutionGraph archivedExecutionGraph = 
archivedExecutionGraphStore.get(jobId);
    +
    +                   if (archivedExecutionGraph == null) {
    +                           return FutureUtils.completedExceptionally(new 
FlinkJobNotFoundException(jobId));
    +                   } else {
    +                           return 
CompletableFuture.completedFuture(JobResult.createFrom(archivedExecutionGraph));
    +                   }
    +           } else {
    +                   return jobManagerRunner.getResultFuture().thenApply(
    --- End diff --
    
    nit: can be rewritten as `return 
jobManagerRunner.getResultFuture().thenApply(JobResult::createFrom);`


> Enable Flip-6 per default
> -------------------------
>
>                 Key: FLINK-8614
>                 URL: https://issues.apache.org/jira/browse/FLINK-8614
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> After adding the FLINK-8471, the next step is to enable Flip-6 per default by 
> setting the configuration switch to {{flip6}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to