[ 
https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372669#comment-16372669
 ] 

ASF GitHub Bot commented on FLINK-8656:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5487#discussion_r169634082
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/util/function/BiConsumerWithException.java
 ---
    @@ -0,0 +1,50 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.util.function;
    +
    +import java.util.function.BiConsumer;
    +
    +/**
    + * A checked extension of the {@link BiConsumer} interface.
    + *
    + * @param <T> type of the first argument
    + * @param <U> type of the second argument
    + * @param <E> type of the thrown exception
    + */
    +@FunctionalInterface
    +public interface BiConsumerWithException<T, U, E extends Throwable> 
extends BiConsumer<T, U> {
    +
    +   /**
    +    * Performs this operation on the given arguments.
    +    *
    +    * @param t the first input argument
    +    * @param u the second input argument
    +    * @throws E in case of an error
    +    */
    +   void acceptWithException(T t, U u) throws E;
    +
    +   @Override
    +   default void accept(T t, U u) {
    +           try {
    +                   acceptWithException(t, u);
    +           } catch (Throwable e) {
    --- End diff --
    
    Normally `Error`s shouldn't be caught 
https://stackoverflow.com/questions/581878/why-catch-exceptions-in-java-when-you-can-catch-throwables


> Add CLI command for rescaling
> -----------------------------
>
>                 Key: FLINK-8656
>                 URL: https://issues.apache.org/jira/browse/FLINK-8656
>             Project: Flink
>          Issue Type: New Feature
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The REST rescaling calls should be made accessible via the {{CliFrontend}}. 
> In order to do that I propose to add a {{modify}} command to the 
> {{CliFrontend}} to which we can pass a new parallelism.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to