[ 
https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372668#comment-16372668
 ] 

ASF GitHub Bot commented on FLINK-8656:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5487#discussion_r169911850
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java 
---
    @@ -447,6 +453,165 @@ public void postStop() throws Exception {
                return CompletableFuture.completedFuture(Acknowledge.get());
        }
     
    +   @Override
    +   public CompletableFuture<Acknowledge> rescaleJob(
    +                   int newParallelism,
    +                   RescalingBehaviour rescalingBehaviour,
    +                   Time timeout) {
    +           final ArrayList<JobVertexID> allOperators = new 
ArrayList<>(jobGraph.getNumberOfVertices());
    +
    +           for (JobVertex jobVertex : jobGraph.getVertices()) {
    +                   allOperators.add(jobVertex.getID());
    +           }
    +
    +           return rescaleOperators(allOperators, newParallelism, 
rescalingBehaviour, timeout);
    +   }
    +
    +   @Override
    +   public CompletableFuture<Acknowledge> rescaleOperators(
    --- End diff --
    
    Does it have to be part of the `JobMasterGateway` interface? It's only used 
from `rescaleJob`.


> Add CLI command for rescaling
> -----------------------------
>
>                 Key: FLINK-8656
>                 URL: https://issues.apache.org/jira/browse/FLINK-8656
>             Project: Flink
>          Issue Type: New Feature
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The REST rescaling calls should be made accessible via the {{CliFrontend}}. 
> In order to do that I propose to add a {{modify}} command to the 
> {{CliFrontend}} to which we can pass a new parallelism.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to