ASF GitHub Bot commented on FLINK-8679:

Github user StefanRRichter commented on a diff in the pull request:

    --- Diff: 
    @@ -61,8 +61,9 @@
         *                 over it keys are not supported.
         * @param state State variable for which existing keys will be returned.
         * @param namespace Namespace for which existing keys will be returned.
    +    * @param namespaceSerializer the serializer for the namespace.
    -   <N> Stream<K> getKeys(String state, N namespace);
    +   <N> Stream<K> getKeys(String state, N namespace, TypeSerializer<N> 
    --- End diff --
    Currently, each registered state has its own column family, so that should 
be ok. What made you think that this does not hold? (asking in case you found 
something that should be fixed)

> RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with 
> namespace
> ------------------------------------------------------------------------------------
>                 Key: FLINK-8679
>                 URL: https://issues.apache.org/jira/browse/FLINK-8679
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Blocker
>             Fix For: 1.5.0
> Currently, `RocksDBKeyedBackend.getKeys(stateName, namespace)` is odds. It 
> doesn't use the namespace to filter data. And 
> `HeapKeyedBackend.getKeys(stateName, namespace)` has done that, I think they 
> should be consistent at least.

This message was sent by Atlassian JIRA

Reply via email to