[ 
https://issues.apache.org/jira/browse/FLINK-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372946#comment-16372946
 ] 

ASF GitHub Bot commented on FLINK-8679:
---------------------------------------

Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5518#discussion_r169993867
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
 ---
    @@ -61,8 +61,9 @@
         *                 over it keys are not supported.
         * @param state State variable for which existing keys will be returned.
         * @param namespace Namespace for which existing keys will be returned.
    +    * @param namespaceSerializer the serializer for the namespace.
         */
    -   <N> Stream<K> getKeys(String state, N namespace);
    +   <N> Stream<K> getKeys(String state, N namespace, TypeSerializer<N> 
namespaceSerializer);
    --- End diff --
    
    Checked! It is me that misunderstand something. The `getPartitionedState 
confused me, it just reset the `namespace` but not reset the 
`namespaceSerializer` for the `previous` state. Please just ignore me... 
Addressing this.


> RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with 
> namespace
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-8679
>                 URL: https://issues.apache.org/jira/browse/FLINK-8679
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> Currently, `RocksDBKeyedBackend.getKeys(stateName, namespace)` is odds. It 
> doesn't use the namespace to filter data. And 
> `HeapKeyedBackend.getKeys(stateName, namespace)` has done that, I think they 
> should be consistent at least.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to