[ 
https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379074#comment-16379074
 ] 

ASF GitHub Bot commented on FLINK-8667:
---------------------------------------

Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/5500
  
    @tillrohrmann  @kl0u Thanks for reviewing, guys 
    
    As @pnowojski mentioned, we three decided to expose timer keys in 
`ProcessFunction` in [FLINK-8560](https://github.com/apache/flink/pull/5481).  
Exposing timer keys in `KeyedBroadcastProcessFunction` extends that design. I 
think we should get this PR into 1.5.0 so we don't need to do the [complicated 
refactoring for FLINK-8560](https://github.com/apache/flink/pull/5481) to 
support backward compatibility 


> expose key in KeyedBroadcastProcessFunction#onTimer()
> -----------------------------------------------------
>
>                 Key: FLINK-8667
>                 URL: https://issues.apache.org/jira/browse/FLINK-8667
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
>
>
> [~aljoscha] [~pnowojski]  
> Since KeyedBroadcastProcessFunction is about to get out of the door, I think 
> it will be great to expose the timer's key in KeyedBroadcastProcessFunction 
> too. If we don't do it now, it will be much more difficult to add the feature 
> on later because of user app compatibility issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to