[
https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380349#comment-16380349
]
ASF GitHub Bot commented on FLINK-8667:
---------------------------------------
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5500#discussion_r171252617
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java
---
@@ -118,7 +118,7 @@
* @throws Exception This method may throw exceptions. Throwing an
exception will cause the operation
* to fail and may trigger recovery.
*/
- public void onTimer(final long timestamp, final OnTimerContext ctx,
final Collector<OUT> out) throws Exception {
+ public void onTimer(final long timestamp, final OnTimerContext<KS> ctx,
final Collector<OUT> out) throws Exception {
--- End diff --
Remove the `<KS>`.
> expose key in KeyedBroadcastProcessFunction#onTimer()
> -----------------------------------------------------
>
> Key: FLINK-8667
> URL: https://issues.apache.org/jira/browse/FLINK-8667
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Major
> Fix For: 1.5.0
>
>
> [~aljoscha] [~pnowojski]
> Since KeyedBroadcastProcessFunction is about to get out of the door, I think
> it will be great to expose the timer's key in KeyedBroadcastProcessFunction
> too. If we don't do it now, it will be much more difficult to add the feature
> on later because of user app compatibility issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
