[
https://issues.apache.org/jira/browse/FLINK-8730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379988#comment-16379988
]
ASF GitHub Bot commented on FLINK-8730:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5546#discussion_r171178145
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/json/SerializedThrowableSerializerTest.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.json;
+
+import org.apache.flink.util.SerializedThrowable;
+
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectMapper;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.module.SimpleModule;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.instanceOf;
+import static org.junit.Assert.assertThat;
+
+/**
+ * Tests for {@link SerializedThrowableSerializer} and {@link
SerializedThrowableDeserializer}.
+ */
+public class SerializedThrowableSerializerTest {
--- End diff --
Missing `TestLogger`.
> Make SerializedThrowable deserialized from JSON re-throwable
> ------------------------------------------------------------
>
> Key: FLINK-8730
> URL: https://issues.apache.org/jira/browse/FLINK-8730
> Project: Flink
> Issue Type: Improvement
> Components: Client, REST
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Critical
>
> Instances of {{org.apache.flink.util.SerializedThrowable}} that are
> deserialized from JSON using {{SerializedThrowableDeserializer}} do not show
> the right stacktrace/message when re-thrown directly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
