[
https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380357#comment-16380357
]
ASF GitHub Bot commented on FLINK-8667:
---------------------------------------
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5500#discussion_r171253275
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperatorTest.java
---
@@ -381,26 +392,28 @@ public void processElement(String value,
KeyedReadOnlyContext ctx, Collector<Str
Iterator<Map.Entry<String, Integer>> iter =
broadcastStateIt.iterator();
for (int i = 0; i < expectedBroadcastState.size(); i++)
{
- Assert.assertTrue(iter.hasNext());
+ assertTrue(iter.hasNext());
Map.Entry<String, Integer> entry = iter.next();
-
Assert.assertTrue(expectedBroadcastState.containsKey(entry.getKey()));
-
Assert.assertEquals(expectedBroadcastState.get(entry.getKey()),
entry.getValue());
+
assertTrue(expectedBroadcastState.containsKey(entry.getKey()));
+
assertEquals(expectedBroadcastState.get(entry.getKey()), entry.getValue());
}
- Assert.assertFalse(iter.hasNext());
+ assertFalse(iter.hasNext());
ctx.timerService().registerEventTimeTimer(timerTs);
}
@Override
- public void onTimer(long timestamp, OnTimerContext ctx,
Collector<String> out) throws Exception {
+ public void onTimer(long timestamp, OnTimerContext<String> ctx,
Collector<String> out) throws Exception {
--- End diff --
Remove the `<String>`.
> expose key in KeyedBroadcastProcessFunction#onTimer()
> -----------------------------------------------------
>
> Key: FLINK-8667
> URL: https://issues.apache.org/jira/browse/FLINK-8667
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Major
> Fix For: 1.5.0
>
>
> [~aljoscha] [~pnowojski]
> Since KeyedBroadcastProcessFunction is about to get out of the door, I think
> it will be great to expose the timer's key in KeyedBroadcastProcessFunction
> too. If we don't do it now, it will be much more difficult to add the feature
> on later because of user app compatibility issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
