[
https://issues.apache.org/jira/browse/FLINK-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384450#comment-16384450
]
ASF GitHub Bot commented on FLINK-8623:
---------------------------------------
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5449#discussion_r172004016
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java
---
@@ -61,7 +61,7 @@ public void testReturnLocalHostAddressUsingHeuristics()
throws Exception {
assertNotNull(add);
// make sure that we returned the
InetAddress.getLocalHost as a heuristic
- assertEquals(InetAddress.getLocalHost(), add);
+ assertEquals(InetAddress.getByName("localhost"), add);
--- End diff --
Thanks @NicoK review. Yes. I think this is a better way to use ```null```
instead of ```InetAddress.getLocalHost()``` to prevent multiple adapters cache
expires from getting a another result in the future. I will give a quick fix
for that.
> ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics unstable on
> Travis
> --------------------------------------------------------------------------------
>
> Key: FLINK-8623
> URL: https://issues.apache.org/jira/browse/FLINK-8623
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Priority: Blocker
> Labels: test-stability
> Fix For: 1.5.0, 1.4.3
>
>
> {{ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics}} fails on
> Travis: https://travis-ci.org/apache/flink/jobs/339344442
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
