[
https://issues.apache.org/jira/browse/FLINK-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385710#comment-16385710
]
ASF GitHub Bot commented on FLINK-8830:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5629#discussion_r172105998
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -496,18 +496,20 @@ static ContainerLaunchContext
createTaskExecutorContext(
// NOTE: must read the tokens from the local file, not
from the UGI context, because if UGI is login
// using Kerberos keytabs, there is no HDFS delegation
token in the UGI context.
String fileLocation =
System.getenv(UserGroupInformation.HADOOP_TOKEN_FILE_LOCATION);
- Method readTokenStorageFileMethod =
Credentials.class.getMethod(
- "readTokenStorageFile", File.class,
org.apache.hadoop.conf.Configuration.class);
-
- Credentials cred =
- (Credentials) readTokenStorageFileMethod.invoke(
- null,
- new File(fileLocation),
-
HadoopUtils.getHadoopConfiguration(flinkConfig));
-
- cred.writeTokenStorageToStream(dob);
- ByteBuffer securityTokens =
ByteBuffer.wrap(dob.getData(), 0, dob.getLength());
- ctx.setTokens(securityTokens);
+ if (fileLocation != null) {
+ Method readTokenStorageFileMethod =
Credentials.class.getMethod(
+ "readTokenStorageFile", File.class,
org.apache.hadoop.conf.Configuration.class);
+
+ Credentials cred =
+ (Credentials)
readTokenStorageFileMethod.invoke(
+ null,
+ new File(fileLocation),
--- End diff --
this will now throw an NPE instead.
> YarnResourceManager throws NullPointerException
> -----------------------------------------------
>
> Key: FLINK-8830
> URL: https://issues.apache.org/jira/browse/FLINK-8830
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: vinoyang
> Priority: Major
>
>
> {code:java}
> java.lang.NullPointerException
> at java.io.File.<init>(File.java:277)
> at org.apache.flink.yarn.Utils.createTaskExecutorContext(Utils.java:502)
> at
> org.apache.flink.yarn.YarnResourceManager.createTaskExecutorLaunchContext(YarnResourceManager.java:445)
> at
> org.apache.flink.yarn.YarnResourceManager.onContainersAllocated(YarnResourceManager.java:338)
> at
> org.apache.flink.yarn.YarnResourceManagerTest$1.<init>(YarnResourceManagerTest.java:340)
> at
> org.apache.flink.yarn.YarnResourceManagerTest.testStopWorker(YarnResourceManagerTest.java:317)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at
> com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
> at
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> {code}
>
> This exception is being thrown in
> `org.apache.flink.yarn.YarnResourceManagerTest#testStopWorker`. Exception
> apparently is being ignored, since the test completes. It seems like this
> line:
> {code:java}
> String fileLocation =
> System.getenv(UserGroupInformation.HADOOP_TOKEN_FILE_LOCATION){code}
> Is not guarded against returned null value. I don't know if that's a test or
> production code issue.
> CC [~till.rohrmann]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
